Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SkipModelConvertScalarSetWrapper #3552

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add SkipModelConvertScalarSetWrapper #3552

merged 3 commits into from
Nov 2, 2023

Conversation

odow
Copy link
Member

@odow odow commented Oct 29, 2023

Closes #3549

@odow odow mentioned this pull request Oct 29, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35e7713) 98.26% compared to head (60865dc) 98.18%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3552      +/-   ##
==========================================
- Coverage   98.26%   98.18%   -0.08%     
==========================================
  Files          37       37              
  Lines        5580     5579       -1     
==========================================
- Hits         5483     5478       -5     
- Misses         97      101       +4
Files Coverage Δ
src/constraints.jl 96.79% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsipher
Copy link
Contributor

Thanks for this. I missed your comment on the issue asking for name suggestions. This name seems a little on the verbose side, but I don't really have a more concise suggestion.

@odow
Copy link
Member Author

odow commented Oct 30, 2023

Yeah, I went for verbosity. I don't imagine that it will be used by users, so it's okay if it is inside DisjunctiveProgramming.jl.

@odow odow requested a review from mlubin October 30, 2023 20:12
@odow
Copy link
Member Author

odow commented Nov 2, 2023

Merging because I think we're okay with this.

@odow odow merged commit b11f744 into master Nov 2, 2023
9 of 11 checks passed
@odow odow deleted the od/skip-model-convert-scalar-set-wrapper branch November 2, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

@mlubin mlubin Awaiting requested review from mlubin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make _DoNotConvertSet Public
3 participants
@odow @pulsipher @blegat